Re: [PATCH 2/2] autogen.sh: Detect python

[Daniel Kiper]

On Wed, Aug 18, 2021 at 09:19:23AM +0200, Petr Vorel wrote:
> > On Mon, Aug 09, 2021 at 01:52:29PM +0200, Daniel Kiper wrote:
> > > On Fri, Aug 06, 2021 at 08:45:08AM +0200, Petr Vorel wrote:
> > > > It help to avoid error on distros which has only python3 binary:
> > > > ./autogen.sh: line 20: python: command not found
>
> > > > Using bash builtin 'command -v' to avoid requiring which as extra
> > > > dependency (usable on containers).
>
> > > It looks the bash dependency is not specified in the INSTALL file in
> > > "The Requirements" section. May I ask you to add it?
>
> > ...and python requirement is missing from the list too. Additionally,
> > please update autogen.sh python usage in the INSTALL file.
> There is Python 2.6 or later, not sure if it still works on 2.6 (which is EOL)
> or it requires now 2.7).

I think we should update this requirement to "Python 3.0.0 or later".

> Also "If you use a development snapshot or want to hack on GRUB you may
> need the following." is obsolete (from 2009), I'll move python, autoconf and
> automake to the list on the top.

OK...

There is also:

  3. Type `./bootstrap'.

     * autogen.sh (called by bootstrap) uses python. By default the
       invocation is "python", but it can be overridden by setting the
       variable $PYTHON.

I think this should be updated too.

> > Last but not least, patch tool requirement is missing from INSTALL file too.
> > Of course this requires update to patch #1 in this series.
> I first thought "Other standard GNU/Unix tools" would cover it, but it does 
> not
> harm to mention it (for those who compile on containers which have minimal
> dependencies).

Yep!

Daniel