[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] commands/setpci: honor write mask argument
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH] commands/setpci: honor write mask argument |
|
Date: |
Fri, 13 Aug 2021 22:41:27 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Thu, Aug 12, 2021 at 04:56:13PM +0200, Wouter van Kesteren wrote:
> In the case that one passes a write mask with :
> the write_mask is obtained from grub_strtoul and then
> promptly overwritten by 0xffffffff three lines later.
>
> This appears to have been so since the initial version of setpci in 2009.
> I'm suprised no one else has hit this issue in the past 12 years...
May I add "Signed-off-by: Wouter van Kesteren <woutershep@gmail.com>" to
this patch?
Otherwise Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel