Re: [PATCH 0/1] PRI* translation issues.

[Daniel Kiper]

Hey,

On Sat, Apr 03, 2021 at 03:33:32PM +0200, Miguel Ángel Arruga Vivas wrote:
> Hi,
>
> Daniel Kiper <dkiper@net-space.pl> writes:
> [...]
> > Thank you for the report!
>
> You're welcome! Sorry for the delay again, I've been a bit busy.

No problem.

> [...]
> > Could you send this patch using "git send-email"?
>
> I hope the updated patch works fine.

LGTM, so, Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

> I have some doubts regarding this acryonym:
>
> > Could you add your SOB here?

Signed-off-by: Miguel Ángel Arruga Vivas <rosen644835@gmail.com>

I can add this for you before committing the patch.

> I added a description of the change there too instead of only making
> the reference to the manual, but certainly I don't know what SOB means

Great! Though I will tweak it a bit before committing.

> in this context, sorry. :-(

No worries.

> Regarding the patch:
>
> >> +                char rel_info[17]; /* log16 (2^64) = 16, plus nul.  */
> >
> > Please add empty line here and s/nul/NUL/.
>
> I've added the empty line and modified the NUL as requested.
>
> >> +                return grub_error (GRUB_ERR_NOT_IMPLEMENTED_YET,
> >> +                                   N_("relocation 0x%s"
> >> +                                      " is not implemented yet"),
> >> +                                   rel_info);
> >
> > Please merge all these 3 lines into one, i.e:
> >   N_("relocation 0x%s" is not implemented yet"), rel_info);
>
> I wasn't quite sure about this, as the column count goes high on my
> Emacs, should I remove some indentation?  Perhaps three lines could be
> another compromise with N_ and rel_info on separate lines as the other
> code?

Yep.

> > Does this patch fix all PRI* translation issues?
>
> I think all PRI* issues facing up the user are covered; I grep'ed the
> code and they seem to be only used for internal messages.

Perfect!

> > When I get next version of patch from you I will rebuild and update pot 
> > file.
>
> Sorry again for the delay, and thank you very much for your support.

You are welcome!

Daniel