Re: [PATCH v4 15/15] luks2: Error check segment.sector_size.

[Daniel Kiper]

On Sun, Nov 15, 2020 at 11:42:24AM +0100, Patrick Steinhardt wrote:
> On Fri, Nov 06, 2020 at 10:44:35PM -0600, Glenn Washburn wrote:
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
>
> Reviewed-by: Patrick Steinhardt <ps@pks.im>
>
> > ---
> >  grub-core/disk/luks2.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> >
> > diff --git a/grub-core/disk/luks2.c b/grub-core/disk/luks2.c
> > index 751b48d6a..b628043e0 100644
> > --- a/grub-core/disk/luks2.c
> > +++ b/grub-core/disk/luks2.c
> > @@ -622,6 +622,17 @@ luks2_recover_key (grub_disk_t source,
> >
> >        grub_dprintf ("luks2", "Trying keyslot %"PRIuGRUB_UINT64_T"\n", 
> > keyslot.slot_key);
> >
> > +      /* Sector size should be one of 512, 1024, 2048, or 4096. */
> > +      if (!(segment.sector_size == 512 || segment.sector_size == 1024 ||
> > +            segment.sector_size == 2048 || segment.sector_size == 4096))
> > +   {
> > +     grub_dprintf ("luks2", "Segment \"%"PRIuGRUB_UINT64_T"\" sector"
> > +                            " size %"PRIuGRUB_UINT64_T" is not one of"
> > +                            " 512, 1024, 2048, or 4096.",
> > +                            segment.slot_key, segment.sector_size);

s/\.$/\n/

Otherwise Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel