[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/10] luks2: Improve readability in luks2_get_keyslot.
From: |
Glenn Washburn |
Subject: |
Re: [PATCH v3 02/10] luks2: Improve readability in luks2_get_keyslot. |
Date: |
Thu, 29 Oct 2020 16:52:55 -0500 |
On Fri, 23 Oct 2020 14:14:52 +0200
Daniel Kiper <dkiper@net-space.pl> wrote:
> On Mon, Oct 19, 2020 at 06:09:50PM -0500, Glenn Washburn wrote:
> > Introduce new variables keyslot_key, digest_key, and segment_key
> > which represent the integer key of the item in the respective
> > associative array when looping over the array items. This replaces
> > using a generically named variable named "idx" used for all three
> > values. The parameter "i" is renamed to "keyslot_idx" and the loop
> > variable "j" is renamed to "i". Error messages now distinguish
> > between indexes and keys. The former include "index" in the error
> > string, and the later are surrounded in quotes.
>
> I think this patch does too many things in one step. Please do one
> rename per patch if possible. Additionally, I think this patch, or
> series of the patches, should be before current patch #1.
>
> Daniel
Okay, I've split these two patches into 5 patches:
5: luks2: Improve error messages in luks2_get_keyslot.
4: luks2: Split idx into three variables: keyslot_key, digest_key,
segment_key.
3: luks2: Rename index variable j to i.
2: luks2: Rename variable i to keyslot_idx in luks2_get_keyslot.
1: luks2: Use correct index variable when looping in luks2_get_keyslot.
I'm traveling the next few days and thinking that it would be best to
send these with the next iteration of the patch series which includes
some of the changes suggested for other patches.
Glenn
- [PATCH v2 09/10] cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors., (continued)
Re: [PATCH v2 00/10] Cryptodisk fixes for v2.06 redux, Patrick Steinhardt, 2020/10/09
[PATCH v3 03/10] luks2: Use more intuitive keyslot key instead of index when naming keyslot., Glenn Washburn, 2020/10/19
Re: [PATCH v3 03/10] luks2: Use more intuitive keyslot key instead of index when naming keyslot., Patrick Steinhardt, 2020/10/23
[PATCH v3 01/10] luks2: Fix use of incorrect index and some grub_error() messages., Glenn Washburn, 2020/10/19
Re: [PATCH v3 01/10] luks2: Fix use of incorrect index and some grub_error() messages., Daniel Kiper, 2020/10/23
Re: [PATCH v3 01/10] luks2: Fix use of incorrect index and some grub_error() messages., Patrick Steinhardt, 2020/10/23
[PATCH v3 07/10] cryptodisk: Replace some literals with constants in grub_cryptodisk_endecrypt., Glenn Washburn, 2020/10/19
Re: [PATCH v3 07/10] cryptodisk: Replace some literals with constants in grub_cryptodisk_endecrypt., Patrick Steinhardt, 2020/10/23
Re: [PATCH v3 07/10] cryptodisk: Replace some literals with constants in grub_cryptodisk_endecrypt., Glenn Washburn, 2020/10/26
Re: [PATCH v3 07/10] cryptodisk: Replace some literals with constants in grub_cryptodisk_endecrypt., Patrick Steinhardt, 2020/10/28