Re: [PATCH v3 09/10] cryptodisk: Rename offset in grub_cryptodisk

grub-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 09/10] cryptodisk: Rename offset in grub_cryptodisk_t to o

From:	Daniel Kiper
Subject:	Re: [PATCH v3 09/10] cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors.
Date:	Tue, 27 Oct 2020 19:07:56 +0100
User-agent:	NeoMutt/20170113 (1.7.2)

On Fri, Oct 23, 2020 at 07:58:13PM +0200, Patrick Steinhardt wrote:
> On Mon, Oct 19, 2020 at 06:09:57PM -0500, Glenn Washburn wrote:
> > This makes it clear that the offset represents sectors, not bytes, in order
> > to improve readability.
> >
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
>
> Reviewed-by: Patrick Steinhardt <ps@pks.im>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v3 10/10] luks2: Rename source disk variabled named 'disk' to 'source' as in luks.c., (continued)

Prev by Date: Re: [PATCH v3 08/10] cryptodisk: Rename total_length field in grub_cryptodisk_t to total_sectors.
Next by Date: Re: [PATCH v3 10/10] luks2: Rename source disk variabled named 'disk' to 'source' as in luks.c.
Previous by thread: Re: [PATCH v3 09/10] cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors.
Next by thread: [PATCH v3 06/10] cryptodisk: Properly handle non-512 byte sized sectors.
Index(es):
- Date
- Thread