[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] shim_lock: Enable module for all EFI platforms
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH] shim_lock: Enable module for all EFI platforms |
|
Date: |
Fri, 18 Sep 2020 23:38:24 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Fri, Sep 18, 2020 at 01:08:15PM +0800, Tianjia Zhang wrote:
> Hi,
>
> On 9/17/20 10:58 PM, Daniel Kiper wrote:
> > On Wed, Jul 29, 2020 at 03:11:09PM +0800, Tianjia Zhang wrote:
> > > Like tpm, the module is only enabled for x86_64, but there's nothing
> > > specific to x86_64 in the implementation and can be enabled for all
> > > EFI platforms.
> > >
> > > Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> > > ---
> > > grub-core/Makefile.core.def | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def
> > > index 166b444c7..b5f47fc41 100644
> > > --- a/grub-core/Makefile.core.def
> > > +++ b/grub-core/Makefile.core.def
> > > @@ -950,7 +950,7 @@ module = {
> > > module = {
> > > name = shim_lock;
> > > common = commands/efi/shim_lock.c;
> > > - enable = x86_64_efi;
> > > + enable = efi;
> >
> > Did you test this with x86 32-bit EFI builds and e.g. ARM64 EFI builds?
> >
> > Daniel
>
> It is tested on x86_64-efi and arm64-efi platforms. I don’t have an
> environment for x86 32-bit EFI, and I haven’t tested on this platform.
It looks that this patch does not break any builds. So, I took it.
Have a nice weekend,
Daniel