|
From: | Paul Menzel |
Subject: | Re: [PATCH] shim_lock: Enable module for all EFI platforms |
Date: | Fri, 18 Sep 2020 08:45:37 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
Dear Tianjia, Thank you for your patch and your reply. Am 18.09.20 um 07:08 schrieb Tianjia Zhang:
On 9/17/20 10:58 PM, Daniel Kiper wrote:On Wed, Jul 29, 2020 at 03:11:09PM +0800, Tianjia Zhang wrote:Like tpm, the module is only enabled for x86_64, but there's nothing specific to x86_64 in the implementation and can be enabled for all EFI platforms. Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> --- grub-core/Makefile.core.def | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 166b444c7..b5f47fc41 100644 --- a/grub-core/Makefile.core.def +++ b/grub-core/Makefile.core.def @@ -950,7 +950,7 @@ module = { module = { name = shim_lock; common = commands/efi/shim_lock.c; - enable = x86_64_efi; + enable = efi;Did you test this with x86 32-bit EFI builds and e.g. ARM64 EFI builds?
It is tested on x86_64-efi and arm64-efi platforms. I don’t have an environment for x86 32-bit EFI, and I haven’t tested on this platform.
Please always mention that in the commit message. Please also be specific about the device you used (mainboard name, firmware name/version and TPM used) and the command you run for the test.
It’d be great if you could test 32-bit EFI with QEMU. Kind regards, Paul
[Prev in Thread] | Current Thread | [Next in Thread] |