[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4][ 5/6] cryptodisk: enable the backends to implement key fi
From: |
Denis 'GNUtoo' Carikli |
Subject: |
Re: [PATCH v4][ 5/6] cryptodisk: enable the backends to implement key files |
Date: |
Thu, 11 Jun 2020 17:28:42 +0200 |
On Mon, 8 Jun 2020 20:50:15 +0200
Patrick Steinhardt <ps@pks.im> wrote:
> > + if (requested_keyfile_size)
> > + {
> > + if (requested_keyfile_size > (keyfile->size -
> > keyfile_offset))
> > + return grub_error (GRUB_ERR_FILE_READ_ERROR,
> > + N_("Keyfile is too small: "
> > \
> > + "requested %" PRIuGRUB_SIZE "
> > bytes, " \
> > + "but the file only has %"
> > PRIuGRUB_SIZE \
> > + " bytes.\n"),
>
> These trailing backslashes aren't required. C handles strings split
> over multiple lines without any need for escaping.
Thanks, I wasn't sure what to do with them and I assumed they were
there because of the (GNU?) code style, which I'm not familiar with.
Denis.
pgpsI9ozJd44u.pgp
Description: OpenPGP digital signature
- v4 for detached headers and key files, Denis 'GNUtoo' Carikli, 2020/06/03
- [PATCH v4][ 1/6] cryptodisk: luks: unify grub_cryptodisk_dev function names, Denis 'GNUtoo' Carikli, 2020/06/03
- [PATCH v4][ 3/6] cryptodisk: enable the backends to implement detached headers, Denis 'GNUtoo' Carikli, 2020/06/03
- [PATCH v4][ 4/6] cryptodisk: add support for LUKS1 detached headers, Denis 'GNUtoo' Carikli, 2020/06/03
- [PATCH v4][ 5/6] cryptodisk: enable the backends to implement key files, Denis 'GNUtoo' Carikli, 2020/06/03
- [PATCH v4][ 6/6] cryptodisk: Add support for LUKS1 key files, Denis 'GNUtoo' Carikli, 2020/06/03
- [PATCH v4][ 2/6] cryptodisk: geli: unify grub_cryptodisk_dev function names, Denis 'GNUtoo' Carikli, 2020/06/03
- Re: v4 for detached headers and key files, Patrick Steinhardt, 2020/06/08