Re: [PATCH REBASED] verify: search keyid in hashed signature subpackets

[Daniel Kiper]

On Fri, May 29, 2020 at 02:10:46PM +1000, Daniel Axtens wrote:
> Charles Duffy <charles@dyfis.net> writes:
>
> > Amended the test repo to apply this patch; it applies and works-as-intended
> > on both 2.04 and current master.
> >
> > As for the DCO assertions, my portion of the contribution was implemented
> > strictly on personal time/equipment, so I'm able to to make the relevant
> > assertions in my individual capacity; amended below thusly.
>
> Awesome, me too.

Oh, nice to see that work revived...

> >> (Add further description per thread at
> >> https://lists.gnu.org/archive/html/grub-devel/2016-11/msg00073.html)
>
> I will leave doing further revisions to you - looking through the thread
> from 2016 it looks like the commit message needs more details and maybe
> some variable names and constants need to be cleaned up etc. Now that we
> have all the relevant Signed-off-bys, that should all be just a matter of
> programming. My understanding is that you should maintain all three

You mean that I have to wait for next version of it...

> S-O-Bs in the commit message for future spins, but I've never been clear
> on what order they should be in if you make further revisions.

Well, it seems to me that it depends on the project and maintainers
preference. I prefer the oldest SOB at the top. So, in this case:

  Signed-off-by: Ignat Korchagin <ignat@cloudflare.com>
  Signed-off-by: Charles Duffy <charles@dyfis.net>
  Signed-off-by: Daniel Axtens <dja@axtens.net>

Daniel