[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/10] i386: Make pmtimer tsc calibration not take 51 seconds
|
From: |
Javier Martinez Canillas |
|
Subject: |
Re: [PATCH 01/10] i386: Make pmtimer tsc calibration not take 51 seconds to fail |
|
Date: |
Mon, 6 Apr 2020 11:32:01 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
Hello Daniel,
On 4/3/20 6:40 PM, Daniel Kiper wrote:
[snip]
>>
>> I've also tested this outcome on a real Intel Xeon E3-1275v3 on an Intel
>> Server Board S1200V3RPS using the SDV.RP.B8 "Release" build here:
>> https://firmware.intel.com/sites/default/files/UEFIDevKit_S1200RP_vB8.zip
>>
>> Signed-off-by: Peter Jones <address@hidden>
>> Signed-off-by: Javier Martinez Canillas <address@hidden>
>
> It seems to me that this is very similar or even the same patch to
> https://lists.gnu.org/archive/html/grub-devel/2018-02/msg00067.html
>
Yes. Since we have been carrying our patches for a long time, before
posting any patch I search in the mailing list if it was previously
proposed and try to address any issues that were pointed out there.
In the future I'll explicit mention this and refer to the old thread
if that's the case.
> If yes I had some comments which were never resolved:
> https://lists.gnu.org/archive/html/grub-devel/2018-02/msg00078.html
>
> If you take my comments into account I am happy to get it into 2.06.
>
I think that addressed most of them. I noticed now that I forgot to add
some comments that you asked to explain why some values were chosen. I
don't know the answer so I'll ask Peter about it and post a new version.
> Daniel
>
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat