Re: [PATCH v1] fix kernel cmdline corruption

[Daniel Kiper]

On Mon, Mar 30, 2020 at 05:04:42PM +0800, Michael Chang wrote:
> On Thu, Mar 26, 2020 at 10:33:01PM +0100, Daniel Kiper wrote:
> > CC-ing Vladimir...
> >
> > On Thu, Mar 19, 2020 at 03:48:28PM +0800, Michael Chang wrote:
> > > Hi Olaf,
> > >
> > > The patch rang a bell to me and eventually I figured out that I had
> > > similar patch posted.
> > >
> > > https://lists.gnu.org/archive/html/grub-devel/2018-04/msg00038.html
> >
> > Yeah, it looks that it fell through the cracks...
> >
> > > In short, the issue is not only in the fix itself, but also to take care
> > > and provide a measure to avoid incompatible grub.cfg before and after
> > > the patch.
> > >
> > > To recap, there were two options provided to deal with the compatibilty
> > > issue.
> > >
> > > 1. Introduce a shell variable to disable the change, whenever anything
> > > goes wrong.
> > >
> > > 2. Use readonly feature variable similar to $feature_menuentry_id that
> > > can be used to detect capability and apply settings accordingly, thus
> > > still fulfill the requirement of one grub.cfg can work for all versions
> > > IMHO.
> > >
> > > I am in favour of #2, but still they didn't seem to have upstream's
> > > consent yet.
> >
> > Michael, please prepare a patch and CC Olaf and Vladimir on it.
>
> OK. I will do so. May I ask is it for 2.06 release material or not ? As
> the deadline is drawing very near I'd better to have confirmation first.

I want to get it fixed in 2.06. Or let's say I would like to have an
option for an user/distro/... to change current behavior if he/she/...
wants to do that. Hence, the patch cannot change the default for 2.06.
We can change that after the release. IMO it is too late for that kind of
experiments...

Daniel