grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] Make editenv chase symlinks including those across de


From: Javier Martinez Canillas
Subject: Re: [PATCH v2 2/2] Make editenv chase symlinks including those across devices
Date: Mon, 28 Oct 2019 18:27:59 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0

Hello Daniel,

Thanks a lot for pointing out these issues. I'll fix them in v2.

>> +
>> +      linkbuf = xmalloc (size+1);
> 
> Please check for NULL here. And "size + 1". In general I will not accept
> any patch which does not check for NULL for malloc() et consortes.
> 

Yes, I'll be more careful when reviewing our downstream patches before posting.

Best regards,
-- 
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat



reply via email to

[Prev in Thread] Current Thread [Next in Thread]