[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] generic/blocklist: Fix flag name
From: |
David Michael |
Subject: |
Re: [PATCH] generic/blocklist: Fix flag name |
Date: |
Fri, 5 Jul 2019 18:25:27 -0400 |
On Fri, Jul 5, 2019 at 6:03 PM Daniel Kiper <address@hidden> wrote:
>
> On Fri, Jul 05, 2019 at 07:45:59AM -0400, David Michael wrote:
> > Signed-off-by: David Michael <address@hidden>
> > ---
> >
> > Hi,
> >
> > I tried to test the new release and hit this build failure:
> >
> > In file included from ../grub-core/osdep/blocklist.c:6:0:
> > ../grub-core/osdep/generic/blocklist.c: In function
> > ‘grub_install_get_blocklist’:
> > ../grub-core/osdep/generic/blocklist.c:62:67: error:
> > ‘FILE_TYPE_NO_DECOMPRESS’ undeclared (first use in this function); did you
> > mean ‘GRUB_FILE_TYPE_NO_DECOMPRESS’?
> > file = grub_file_open (core_path_dev, GRUB_FILE_TYPE_NONE |
> > FILE_TYPE_NO_DECOMPRESS);
> >
> > ^~~~~~~~~~~~~~~~~~~~~~~
> >
> > GRUB_FILE_TYPE_NO_DECOMPRESS
> > ../grub-core/osdep/generic/blocklist.c:62:67: note: each undeclared
> > identifier is reported only once for each function it appears in
> >
> > It seems to be fixed by this change. Can it be applied for the next
> > release?
>
> Hmmm... How come? Several people at least build tested GRUB before
> release and this did not surface. Could you tell us which options you
> use with configure script? Anyway, patch LGTM but I want to know why the
> breakage did not appeared earlier.
It looks like it's because I built it for Hurd, and the error is only
present in the non-Linux/Windows version of that file. The top-level
osdep/blocklist.c file is just the following:
#ifdef __linux__
#include "linux/blocklist.c"
#elif defined (__MINGW32__) || defined (__CYGWIN__)
#include "windows/blocklist.c"
#else
#include "generic/blocklist.c"
#endif
So I think the release is okay for the common platforms.
Thanks.
David