[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] probe: Support probing for GPT partition UUID with -q

From: Paul Menzel
Subject: Re: [PATCH v3] probe: Support probing for GPT partition UUID with -q
Date: Mon, 13 May 2019 13:30:48 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

Dear Jacob,

On 10.05.19 14:05, Jacob Kroon wrote:
Linux supports root=PARTUUID=<partuuid> boot argument, so add
support for probing it. Compared to the fs UUID, the partition
UUID does not change when reformatting a partition.

How did you choose the switch name `-q`? Are other tools using this already, or was it just available?

Signed-off-by: Jacob Kroon <address@hidden>
  grub-core/commands/probe.c | 35 +++++++++++++++++++++++++++++++++++
  1 file changed, 35 insertions(+)

It’d be awesome if you also updated the documentation/manual `docs/grub.texi`.

Changes since v2:

  * Add a proper commit message
  * Handle endianess in the same way as is currently done in
    util/grub-probe.c:print_gpt_guid ()

diff --git a/grub-core/commands/probe.c b/grub-core/commands/probe.c
index 95d272287..24742c181 100644
--- a/grub-core/commands/probe.c
+++ b/grub-core/commands/probe.c
@@ -24,6 +24,7 @@
  #include <grub/device.h>
  #include <grub/disk.h>
  #include <grub/partition.h>
+#include <grub/gpt_partition.h>
  #include <grub/net.h>
  #include <grub/fs.h>
  #include <grub/file.h>
@@ -45,6 +46,7 @@ static const struct grub_arg_option options[] =
      {"fs",          'f', 0, N_("Determine filesystem type."), 0, 0},
      {"fs-uuid",             'u', 0, N_("Determine filesystem UUID."), 0, 0},
      {"label",               'l', 0, N_("Determine filesystem label."), 0, 0},
+    {"partuuid",     'q', 0, N_("Determine GPT partition uuid."), 0, 0},

UUID is capitalized in the string above. Do it her too for consistency?


Kind regards,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]