[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] video: skip 'text' gfxpayload if not supported, to fallback
|
From: |
Mathieu Trudel-Lapierre |
|
Subject: |
Re: [PATCH] video: skip 'text' gfxpayload if not supported, to fallback to default |
|
Date: |
Fri, 10 May 2019 09:24:53 -0400 |
On Fri, May 10, 2019 at 7:52 AM Didier Spaier <address@hidden> wrote:
>
> On 10/05/2019 13:38, Daniel Kiper wrote:
> > On Mon, Apr 29, 2019 at 01:57:02PM -0400, Mathieu Trudel-Lapierre wrote:
> >> On UEFI, 'text' gfxpayload is not supported, but we still reach
> >> parse_modespec
> >> with it, which will obviously fail. Fortunately, whatever gfxpayload is
> >> set,
> >> we still still have the 'auto' default to fall back to. Allow getting to
> >> this
> >> fallback by not trying to parse 'text' as a modespec.
> >>
> >> This is because 'text' correctly doesn't parse as a modespec, and ought to
> >> have
> >> been ignored before we got to that point, just like it is immediately
> >> picked if
> >> we're running on a system where 'text' is a supported video mode.
>
> As an aside, in a grub.cfg intended for both legacy and UEFI booting, can I
> condition setting either 'vga=normal' or 'gfxpayload=text' depending on the
> context detected by grub? If yes, how?
>
In grub.cfg; you can check if you're on the right platform by checking
$grub_platform
On UEFI, it will read "efi".
--
Mathieu Trudel-Lapierre <address@hidden>
Freenode: cyphermox, Jabber: address@hidden
4096R/65B58DA1 818A D123 0992 275B 23C2 CF89 C67B B4D6 65B5 8DA1