[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/5] Various GRUB build fixes
From: |
Daniel Kiper |
Subject: |
Re: [PATCH 0/5] Various GRUB build fixes |
Date: |
Wed, 20 Mar 2019 13:02:14 +0100 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Mar 19, 2019 at 11:16:52AM -0400, Ross Philipson wrote:
> On 03/19/2019 08:39 AM, Daniel Kiper wrote:
> > Hey,
> >
> > As in subject... I am CC-ing folks who were somehow involved in
> > doing/reviewing patches touching broken files. If I missed somebody
> > then sorry about that. Anyway, please take a look.
> >
> > There are still broken builds which I am going to fix soon. However,
> > fortunately most of our targets build without any issue right now.
> >
> > Daniel
> >
> > grub-core/kern/compiler-rt.c | 5 +++--
> > grub-core/loader/ia64/efi/linux.c | 3 +--
> > grub-core/loader/mips/linux.c | 2 +-
> > grub-core/loader/powerpc/ieee1275/linux.c | 4 ++--
> > include/grub/compiler-rt.h | 4 +++-
> > 5 files changed, 10 insertions(+), 8 deletions(-)
> >
> > Daniel Kiper (5):
> > verifiers: IA-64 fallout cleanup
>
> It seems like the things fixed in these two would have prevented
> compiling. I guess it was not tried on these platforms?
Nope.
> > verifiers: PowerPC fallout cleanup
> > verifiers: MIPS fallout cleanup> mips: Enable __clzsi2()
> > sparc: Enable __clzsi2() and __clzdi2()
> >
>
> Anyway, LGTM
>
> Reviewed-by: Ross Philipson <address@hidden>
Thanks a lot! Patches have been pushed.
Daniel
- [PATCH 0/5] Various GRUB build fixes, Daniel Kiper, 2019/03/19
- [PATCH 1/5] verifiers: IA-64 fallout cleanup, Daniel Kiper, 2019/03/19
- [PATCH 2/5] verifiers: PowerPC fallout cleanup, Daniel Kiper, 2019/03/19
- [PATCH 3/5] verifiers: MIPS fallout cleanup, Daniel Kiper, 2019/03/19
- [PATCH 4/5] mips: Enable __clzsi2(), Daniel Kiper, 2019/03/19
- [PATCH 5/5] sparc: Enable __clzsi2() and __clzdi2(), Daniel Kiper, 2019/03/19
- Re: [PATCH 0/5] Various GRUB build fixes, Ross Philipson, 2019/03/19
- Re: [PATCH 0/5] Various GRUB build fixes,
Daniel Kiper <=