[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 08/10] net: dhcp: allow receiving DHCP OFFER and ACK packe
Re: [PATCH v3 08/10] net: dhcp: allow receiving DHCP OFFER and ACK packets
Fri, 8 Mar 2019 17:02:00 +0100
On Fri, Mar 08, 2019 at 12:21:20PM +0000, Andre Przywara wrote:
> On Fri, 8 Mar 2019 13:01:33 +0100
> Daniel Kiper <address@hidden> wrote:
> > On Thu, Mar 07, 2019 at 03:14:14PM +0000, Andre Przywara wrote:
> > > From: Andrei Borzenkov <address@hidden>
> > >
> > > In respone to a BOOTREQUEST packet a BOOTP server would answer with a
> > > BOOTREPLY packet, which ends the conversation for good.
> > > DHCP uses a 4-way handshake, where the initial server respone is an OFFER,
> > > which has to be answered with REQUEST by the client again, only to be
> > > completed by an ACKNOWLEDGE packet from the server.
> > >
> > > Teach the grub_net_process_dhcp() function to deal with OFFER packets,
> > > and treat ACK packets the same es BOOTREPLY packets.
> > >
> > > Signed-off-by: Andre Przywara <address@hidden>
> > > Reviewed-by: Daniel Kiper <address@hidden>
> > This patch has changed and you retained my RB and not explained why it
> > has changed. Could you tell us what has happened? Next time please drop
> > RB if you change the code significantly.
> Mmh, weird. I didn't touch this patch at all, that's why just added your
> R-B to the commit message. I think what happened is that the subtle change
> in patch 05/10 (just removing the not needed brackets, as per your comment
> on v2 4/9), caused the *diff* to be vastly different. I remember fixing it
> up in the "git rebase -i" process. I just did a:
> $ diff -u <(git show dhcp-v2~2:grub-core/net/bootp.c) <(git show
> and that showed only unrelated changes.
> So the resulting code change is actually identical, it's just that diff
> took a different approach at expressing that.
> Sorry for the confusion, hope that your R-b: still stands.
Gosh... I made a mistake when I have been comparing the patches. My fault.
So, I am taking back my rant. Sorry about that. R-b: still stands.
[PATCH v3 05/10] net: dhcp: make grub_net_process_dhcp take an interface, Andre Przywara, 2019/03/07
[PATCH v3 04/10] net: dhcp: refactor DHCP packet transmission into separate function, Andre Przywara, 2019/03/07
[PATCH v3 07/10] net: dhcp: use DHCP options for name and bootfile, Andre Przywara, 2019/03/07
[PATCH v3 08/10] net: dhcp: allow receiving DHCP OFFER and ACK packets, Andre Przywara, 2019/03/07
[PATCH v3 09/10] net: dhcp: actually send out DHCPv4 DISCOVER and REQUEST messages, Andre Przywara, 2019/03/07
[PATCH v3 06/10] net: dhcp: introduce per-interface timeout, Andre Przywara, 2019/03/07
[PATCH v3 10/10] net: dhcp: add explicit net_dhcp command, Andre Przywara, 2019/03/07
Re: [PATCH v3 00/10] net: bootp: add native DHCPv4 support, Daniel Kiper, 2019/03/08
- Re: [PATCH v3 03/10] net: dhcp: Allow overloading legacy bootfile and name field, (continued)