[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] Upgrade Gnulib; switch to bootstrap tool
From: |
Daniel Kiper |
Subject: |
Re: [PATCH 1/1] Upgrade Gnulib; switch to bootstrap tool |
Date: |
Wed, 16 Jan 2019 21:03:40 +0100 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, Jan 09, 2019 at 12:29:30PM +0000, Colin Watson wrote:
> Upgrade Gnulib files to 20190105.
>
> It's much easier to maintain GRUB's use of portability support files
> from Gnulib when the process is automatic and driven by a single
> configuration file, rather than by maintainers occasionally running
> gnulib-tool and committing the result. Removing these
> automatically-copied files from revision control also removes the
> temptation to hack the output in ways that are difficult for future
> maintainers to follow. Gnulib includes a "bootstrap" program which is
> designed for this.
>
> The canonical way to bootstrap GRUB from revision control is now
> "./bootstrap", but "./autogen.sh" is still useful if you just want to
> generate the GRUB-specific parts of the build system.
>
> GRUB now requires Autoconf >= 2.63 and Automake >= 1.11, in line with
> Gnulib.
Could you update INSTALL file too?
Additionally, if you do such huge change could you move Gnulib from
grub-core/gnulib to grub-core/lib/gnulib? Including all diffs which are
currently outside of grub-core/gnulib directory. Well, maybe *.diff
files should be renamed to *.patch...
Could you add to the commit message how to exactly update Gnulib?
Just list of steps like in the commit 461f1d8af (Import upstream
zstd-1.3.6).
Daniel