Re: [PATCH V2 2/3] verifiers: Core TPM support

[Daniel Kiper]

On Mon, Nov 26, 2018 at 05:00:03PM +1100, Matthew Garrett wrote:
> On Mon, Nov 26, 2018 at 4:47 PM Daniel Kiper <address@hidden> wrote:
>
> > I have a feeling that both UEFI and TIS TPM implementations can coexists
> > together even on UEFI platform. Of course, AIUI, UEFI TPM should be default
> > if we play with TPM 2.0. TIS implementation should be used with TPM 1.2
> > or if UEFI is buggy and its hooks does not work well with TPM 2.0.
> > Does it make sense?
>
> The implementation here should work fine with TPM 1.2, so the only

Hmmm... IIRC UEFI interface only supports TPM 2.0. However, there is
a chance that I am missing something.

> reason to avoid the UEFI implementation is if it's buggy - but given
> current versions of Windows will use the TPM by default if it's
> available, I'd be surprised if there's any significant bugs in the
> wild. I'm not sure there's a real case where you'd have a TPM on a
> UEFI system without having working firmware support, and if you don't
> have the firmware support I don't know how you'd discover the TPM in
> the first place (eg, if it's on SPI we'd need a full SPI
> implementation in grub to talk to it)

OK, let's go ahead then. If at some point it come out that we need direct
communication with TPM then we can add it later.

Just please take into account my minor comments for v2.

Daniel