[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: arm64/xen: Fix implicit declaration of function ‘grub_file_filter_di

From: Julien Grall
Subject: Re: arm64/xen: Fix implicit declaration of function ‘grub_file_filter_disable_compression
Date: Tue, 20 Nov 2018 11:56:19 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1


On 20/11/2018 11:22, Lee Jones wrote:
On Tue, 20 Nov 2018, Julien Grall wrote:
On 20/11/2018 10:46, Lee Jones wrote:
From: Lee Jones <address@hidden>

arm64/xen: Fix implicit declaration of function 

This patch seems to drop support for --nounzip. Can you explain why?

It only seemed to serve the invocation of grub_file_filter_disable_compression()
which was removed in this patch.

But --nounzip will not work as expected after this patch. Looking at GRUB, it seems the call to that function was replaced by passing GRUB_FILE_TYPE_NO_DECOMPRESSION to grub_file_open.

Is there any reason to not use it for Arm?


 On closer inspection, I do see that
argv/argc still needs to be shifted though.  I will fix that.

Note that the option added on Arm64 to keep the compatibility with x86
multiboot loading.

Julien Grall

reply via email to

[Prev in Thread] Current Thread [Next in Thread]