Re: [PATCH v2 05/18] xen: add some dummy headers for PVH mode

[Juergen Gross]

On 18/10/2018 17:19, Daniel Kiper wrote:
> On Tue, Oct 09, 2018 at 01:03:04PM +0200, Juergen Gross wrote:
>> Xen PVH mode needs some headers including the common i386 headers.
>> Add those to the tree.
>>
>> Signed-off-by: Juergen Gross <address@hidden>
>> ---
>>  include/grub/i386/xenpvh/boot.h    | 1 +
>>  include/grub/i386/xenpvh/console.h | 1 +
>>  include/grub/i386/xenpvh/int.h     | 1 +
>>  include/grub/i386/xenpvh/memory.h  | 1 +
>>  include/grub/i386/xenpvh/time.h    | 1 +
>>  5 files changed, 5 insertions(+)
>>  create mode 100644 include/grub/i386/xenpvh/boot.h
>>  create mode 100644 include/grub/i386/xenpvh/console.h
>>  create mode 100644 include/grub/i386/xenpvh/int.h
>>  create mode 100644 include/grub/i386/xenpvh/memory.h
>>  create mode 100644 include/grub/i386/xenpvh/time.h
>>
>> diff --git a/include/grub/i386/xenpvh/boot.h 
>> b/include/grub/i386/xenpvh/boot.h
>> new file mode 100644
>> index 000000000..6cd23aa83
>> --- /dev/null
>> +++ b/include/grub/i386/xenpvh/boot.h
>> @@ -0,0 +1 @@
>> +#include <grub/i386/pc/boot.h>
>> diff --git a/include/grub/i386/xenpvh/console.h 
>> b/include/grub/i386/xenpvh/console.h
>> new file mode 100644
>> index 000000000..305a46d8e
>> --- /dev/null
>> +++ b/include/grub/i386/xenpvh/console.h
>> @@ -0,0 +1 @@
>> +#include <grub/i386/pc/console.h>
>> diff --git a/include/grub/i386/xenpvh/int.h b/include/grub/i386/xenpvh/int.h
>> new file mode 100644
>> index 000000000..6f9d14a81
>> --- /dev/null
>> +++ b/include/grub/i386/xenpvh/int.h
>> @@ -0,0 +1 @@
>> +#include <grub/i386/pc/int.h>
>> diff --git a/include/grub/i386/xenpvh/memory.h 
>> b/include/grub/i386/xenpvh/memory.h
>> new file mode 100644
>> index 000000000..8dd6f7c8c
>> --- /dev/null
>> +++ b/include/grub/i386/xenpvh/memory.h
>> @@ -0,0 +1 @@
>> +#include <grub/i386/coreboot/memory.h>
>> diff --git a/include/grub/i386/xenpvh/time.h 
>> b/include/grub/i386/xenpvh/time.h
>> new file mode 100644
>> index 000000000..2298ee8f4
>> --- /dev/null
>> +++ b/include/grub/i386/xenpvh/time.h
>> @@ -0,0 +1 @@
>> +#include <grub/i386/pc/time.h>
> 
> I do not understand why we need these files. And commit message just states
> just that we need them. However, it says nothing why... So, why? Who will
> use them?

Any source including grub/machine/*.h

I'll make the commit message more verbose in this regard.


Juergen