Re: [PATCH v3 1/6] efi: add central copy of grub_efi_find_mmap_size

[Daniel Kiper]

On Fri, Jul 06, 2018 at 06:13:30PM +0100, Leif Lindholm wrote:
> On Fri, Jul 06, 2018 at 06:55:51PM +0200, Daniel Kiper wrote:
> > On Fri, Jul 06, 2018 at 05:21:17PM +0100, Leif Lindholm wrote:
> > > On Fri, Jul 06, 2018 at 05:00:45PM +0200, Daniel Kiper wrote:
> > > > On Wed, Jun 27, 2018 at 06:17:15PM +0100, Leif Lindholm wrote:
> > > > > There are several implementations of this function in the tree.
> > > > > Add a central version in grub-core/efi/mm.c.
> > > >
> > > > I am happy with the code itself but I am not sure why you are
> > > > not replacing these "several implementations of this function"
> > > > in the existing code. I would like to see a patch which does that.
> > >
> > > I am happy to submit further cleanup patches once this set gets in,
> > > but this is a fundamental change in behaviour compared to those other
> > > bits of code (which I do not exercise or use). It is also a
> > > fundamental change in behaviour compared to the previous version
> > > submitted. I feel a temporary duplication minimises risk of further
> > > disruption.
> >
> > OK, I will take this patch if you promise to fix this in separate patch
> > series later. Later means weeks not years. Of course I am happy to help
> > with this.
>
> I promise to send an RFC out next week.
> After that, I'll be basically offline for two weeks.
>
> What I cannot promise is validating my patches outside of QEMU/Ovmf,
> or figuring out special workarounds if it turns out this new mechanism
> does not work on some (broken) UEFI implementations. If we come across
> anything like that, then I would suggest we keep the duplication.
>
> The RFC will remove all caching of the memory map, which always felt a
> bit dubious to me.

That works for me. Thank you!

Have a nice weekend,

Daniel