Re: [PATCH] bootp: set is_def while processing dhcp ack

[Nikunj A Dadhania]

Andrei Borzenkov <address@hidden> writes:

> On Fri, Mar 18, 2016 at 9:08 AM, Nikunj A Dadhania
> <address@hidden> wrote:
>>>>>>
>>>>>>> I wonder if anyone ever seen or used net_if_dhcp_server_name variable;
>>>>>>> because net_boot sets interface name to card:dhcp, this actually
>>>>>>> becomes net_card_dhcp_dhcp_server_name. Someone would sure have
>>>>>>> noticed it.
>>>>>>
>>>>>
>>>>> Please test attached patch. It sets net_<card>_dhcp_server_ip variable.
>>>>>
>>>>> We probably need to offer programmatic way to iterate through all cards
>>>>> in CLI. But as long as you have single card with known name it should be
>>>>> OK.
>>>>
>>>> So the variable net_ofnet_net_dhcp_server_ip is set now, although the
>>>> boot does not proceed and bails out.
>>>>
>>>
>>> There is misunderstanding. Of course you need to change your script to
>>> actually use this variable. It does not magically set default server.
>>
>> Yes, i was expecting that setting *device=tftp,server-ip might do the
>> trick.
>>
>> So I did following for picking up the server IP, and this works:
>>
>>     set net_default_server=$net_ofnet_net_dhcp_server_ip
>>
>> As you had mentioned, can we have a programmatic way ?
>>
>
> The above looks pretty much programmatic to me :)

Sure, this will do :)

> That's more a policy question - how do you determine which
> card/interface to use (remember, there could be any number of them).
> As you come here from disk boot, you could define card name in
> environment block as example.

Thanks for the support, you are free to add my

Tested-by:  Nikunj A Dadhania <address@hidden>