[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/23] x86/boot: remove unneeded instruction
From: |
Konrad Rzeszutek Wilk |
Subject: |
Re: [PATCH v2 01/23] x86/boot: remove unneeded instruction |
Date: |
Fri, 24 Jul 2015 12:22:57 -0400 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jul 20, 2015 at 04:28:56PM +0200, Daniel Kiper wrote:
> Signed-off-by: Daniel Kiper <address@hidden>
Don't you use it in:
/* Switch to low-memory stack. */
193 mov sym_phys(trampoline_phys),%edi
194 lea 0x10000(%edi),%esp
195 lea trampoline_boot_cpu_entry-trampoline_start(%edi),%eax
?
> ---
> xen/arch/x86/boot/head.S | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/xen/arch/x86/boot/head.S b/xen/arch/x86/boot/head.S
> index cfd59dc..f63b349 100644
> --- a/xen/arch/x86/boot/head.S
> +++ b/xen/arch/x86/boot/head.S
> @@ -169,7 +169,6 @@ __start:
> /* Apply relocations to bootstrap trampoline. */
> mov sym_phys(trampoline_phys),%edx
> mov $sym_phys(__trampoline_rel_start),%edi
> - mov %edx,sym_phys(trampoline_phys)
> 1:
> mov (%edi),%eax
> add %edx,(%edi,%eax)
> --
> 1.7.10.4
>
- [PATCH v2 00/23] x86: multiboot2 protocol support, Daniel Kiper, 2015/07/20
- [PATCH v2 01/23] x86/boot: remove unneeded instruction, Daniel Kiper, 2015/07/20
- Re: [PATCH v2 01/23] x86/boot: remove unneeded instruction,
Konrad Rzeszutek Wilk <=
- [PATCH v2 04/23] x86/boot: call reloc() using cdecl calling convention, Daniel Kiper, 2015/07/20
- [PATCH v2 03/23] x86: zero BSS using stosl instead of stosb, Daniel Kiper, 2015/07/20
- [PATCH v2 07/23] x86/boot/reloc: Rename some variables and rearrange code a bit, Daniel Kiper, 2015/07/20
- [PATCH v2 06/23] x86/boot: use %ecx instead of %eax, Daniel Kiper, 2015/07/20
- [PATCH v2 05/23] x86/boot/reloc: create generic alloc and copy functions, Daniel Kiper, 2015/07/20
- [PATCH v2 08/23] x86: add multiboot2 protocol support, Daniel Kiper, 2015/07/20
- [PATCH v2 11/23] efi: split out efi_init(), Daniel Kiper, 2015/07/20
- [PATCH v2 12/23] efi: split out efi_console_set_mode(), Daniel Kiper, 2015/07/20
- [PATCH v2 02/23] x86/boot: copy only text section from *.lnk file to *.bin file, Daniel Kiper, 2015/07/20