[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] i386/relocator: Remove unused avoid_efi_bootservices arg
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH 3/5] i386/relocator: Remove unused avoid_efi_bootservices argument |
|
Date: |
Thu, 16 Jul 2015 14:02:14 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jul 15, 2015 at 07:50:51PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko
wrote:
> On 30.05.2015 07:25, Andrei Borzenkov wrote:
> > В Fri, 29 May 2015 22:58:43 +0200
> > Daniel Kiper <address@hidden> пишет:
> >
> >> Another questions is why grub_relocator_alloc_chunk_addr() does not
> >> consult EFI
> >> memory map if grub_relocator_alloc_chunk_align() does. Should not we fix
> >> it?
> >
> > My best guess is that grub_relocator_alloc_chunk_addr() gets target
> > from elsewhere so there is nothing to consult (it is caller
> > responsibility); while grub_relocator_alloc_chunk_align() needs to
> > actually search for suitable memory region.
> >
> My suggestion would be to pass avoid_boot_services = 1 in multiboot2 iff
> we don't terminate the services. Any problems with this approach?
I am just working on new GRUB2 patches. I thought to go that way. I hope
this is good idea. Probably I will post new version of patches next week.
Daniel