[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: disk/ahci: Unaligned pointer with old commit as coreboot payload
From: |
Paul Menzel |
Subject: |
Re: disk/ahci: Unaligned pointer with old commit as coreboot payload |
Date: |
Sun, 24 May 2015 20:33:57 +0200 |
Dear Andrei,
Am Sonntag, den 24.05.2015, 21:23 +0300 schrieb Andrei Borzenkov:
> В Sun, 24 May 2015 14:30:28 +0200 Paul Menzel пишет:
> > Am Sonntag, den 24.05.2015, 13:15 +0300 schrieb Andrei Borzenkov:
> > > В Sun, 24 May 2015 09:03:40 +0200 Paul Menzel пишет:
> > >
> > > > further trying to bisect the AHCI regression on, that the GRUB payload
> > > > does not detect the AHCI drive [1], I tried to build GRUB from commits
> > > > changing `grub-core/disk/ahci.c`, I built commit dc2a6c8b (Improve AHCI
> > > > detection and command issuing.), but it it fails to boot with
> > > >
> > > > Unaligned pointer …
> > > > Aborted.
> > > >
> > > > The same happens, when I just checkout that revision for `ahci.c` and
> > > > leave the rest as is.
> > > >
> > > > $ git checkout dc2a6c8b0e3dfe3bce78dbe0febcd9d4d9038411 --
> > > > grub-core/disk/ahci.c
> > > > $ ./autogen.sh
> > > > $ ./configure --with-plattform=coreboot
> > > > $ make -j
> > > > $ make default_payload.elf
> > > >
> > > > I’ll attach that version of `ahci.c` to this message. Do you see what
> > > > could be causing that unaligned pointer?
> > > >
> > >
> > > It is not clear - do you mean that this specific revision has this
> > > problem and others not? Or that this problem happens since this
> > > revision?
> >
> > It’s happening whenever `ahci.c` from commit dc2a6c8b is used (with
> > commit dc2a6c8b and master).
>
> It does not really answer my question - do you get this unaligned access
> with current master?
Sorry for the misunderstand. I do *not* get this unaligned access with
current master. `ahci.c` was rewritten after commit dc2a6c8b.
Thanks,
Paul
signature.asc
Description: This is a digitally signed message part