[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] disk/ahci: Use defines `GRUB_ATA_STATUS_BUSY` and `GRUB_ATA_
From: |
Andrei Borzenkov |
Subject: |
Re: [PATCH] disk/ahci: Use defines `GRUB_ATA_STATUS_BUSY` and `GRUB_ATA_STATUS_DRQ` |
Date: |
Sun, 24 May 2015 21:19:44 +0300 |
В Sun, 24 May 2015 16:48:42 +0200
Paul Menzel <address@hidden> пишет:
> Date: Sun, 24 May 2015 11:11:25 +0200
>
> Instead of hard coding `0x88` use the macros defined in `disk/ata.h`.
applied
> ---
> grub-core/disk/ahci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/grub-core/disk/ahci.c b/grub-core/disk/ahci.c
> index d6bdbdd..7f75724 100644
> --- a/grub-core/disk/ahci.c
> +++ b/grub-core/disk/ahci.c
> @@ -565,14 +565,14 @@ grub_ahci_pciinit (grub_pci_device_t dev,
> while (grub_get_time_ms () < endtime)
> {
> for (i = 0; i < nports; i++)
> - if (adevs[i] && (adevs[i]->hba->ports[adevs[i]->port].task_file_data &
> 0x88))
> + if (adevs[i] && (adevs[i]->hba->ports[adevs[i]->port].task_file_data &
> (GRUB_ATA_STATUS_BUSY | GRUB_ATA_STATUS_DRQ)))
> break;
> if (i == nports)
> break;
> }
>
> for (i = 0; i < nports; i++)
> - if (adevs[i] && (adevs[i]->hba->ports[adevs[i]->port].task_file_data &
> 0x88))
> + if (adevs[i] && (adevs[i]->hba->ports[adevs[i]->port].task_file_data &
> (GRUB_ATA_STATUS_BUSY | GRUB_ATA_STATUS_DRQ)))
> {
> grub_dprintf ("ahci", "port %d is busy\n", i);
> failed_adevs[i] = adevs[i];
pgpc5mFhXEIQ_.pgp
Description: OpenPGP digital signature