grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Parse commandline in grub-xen


From: Olaf Hering
Subject: Re: [PATCH] Parse commandline in grub-xen
Date: Mon, 11 May 2015 11:43:20 +0200
User-agent: Mutt/1.5.22.rev6346 (2013-10-29)

On Mon, May 11, Vladimir 'phcoder' Serbinenko wrote:

> As said previously, allowing setting arbitrary variables from command line 
> will
> not be an accepted behavior. Also the code should be generic enough to allow
> handling of other platforms if need be but surely without including any
> unnecessary code for platforms that don't need it. Until there is an agreement
> on how to handle the arguments, the only patch I would accept is to remove the
> parser in ieee1275 code

The function as is looks generic enough to be used by xen and ieee1275.
Not sure why they went for ';' as separator, I'm sure the firmware does
not require that.
I dont have an EFI capable box around, someone familiar with that could
make use of that function. I'm sure EFI has something like
/chosen/bootargs.

Futhermore what freedom would you like to hand out to those who
implement the scripts? In my testing some variables such as root= and
prefix= are overriden anyway.

Olaf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]