grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 06/23] Add IEEE1275_ADDR helper


From: Andrey Borzenkov
Subject: Re: [RFC PATCH 06/23] Add IEEE1275_ADDR helper
Date: Tue, 1 Apr 2014 21:11:23 +0400

В Wed, 26 Feb 2014 10:31:05 -0800
Ram Pai <address@hidden> пишет:

> From: Anton Blanchard <address@hidden>
> 
> If the target pointer size doesn't match the IEEE1275 cell size, we
> need to cast twice to avoid a warning.
> 
> >  
> +#define IEEE1275_ADDR(x)         (grub_uint32_t)(grub_addr_t)(x)
> +


Should not this be conditional on sizeof(grub_ieee1275_cell_t)?
Otherwise it seems to truncate value on platform where it is 64 bit
(sparc64)?

Is it possible that pointer does exceed 32 bits?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]