Re: grub-shell: Pass -no-pad to xorriso when building floppy images

[Andrey Borzenkov]

В Wed, 22 Jan 2014 16:12:26 +0100
Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:

> On 16.01.2014 15:53, Colin Watson wrote:
> > On Thu, Jan 16, 2014 at 03:05:44PM +0100, Thomas Schmitt wrote:
> >> Hi,
> >>
> >>> +    mkrescue_args="${mkrescue_args} -- -no-pad"
> >>
> >> This "--" is most probably not what you want.
> > [...]
> >>   mkrescue_args="${mkrescue_args} -no-pad"
> > 
> > This doesn't work for me:
> > 
> >   + pkgdatadir=. ./grub-mkrescue --output=/tmp/tmp.NiHozwqHYv 
> > --override-directory=./grub-core --rom-directory=/tmp/tmp.Z4Kx63yul8 
> > --themes-directory=../../themes --compress=xz --fonts= --locales= --themes= 
> > -no-pad /boot/grub/grub.cfg=/tmp/tmp.pEYe6QbufK 
> > /boot/grub/testcase.cfg=/tmp/tmp.8OxC8koxHb
> >   ./grub-mkrescue: invalid option -- 'n'
> >   Try 'grub-mkrescue --help' or 'grub-mkrescue --usage' for more 
> > information.
> > 
> Hm, that's annoying that xorrisofs has single-dash long parameters.
> Perhaps we shouldn't use argp for parsing arguments in mkrescue but own,
> simpler code.


TBO I do not think it is worth it. Intermixing native and xorrisofs
options is probably not a good idea anyway from usability point of
view. Passing non-option arguments still works as before; and for
options it is custom to use "--" to disambiguate non-option arguments
starting with dash (and xorrisofs options are non-option argument for
grub-mkrescue).

signature.asc
Description: PGP signature