[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] grub-core/term/efi/console.c: Use EFI_SIMPLE_TEXT_INPUT_EX_P

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] grub-core/term/efi/console.c: Use EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL if available
Date: Mon, 30 Dec 2013 08:47:25 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10

On 29.12.2013 08:04, Josh Triplett wrote:
> +  term->data = grub_efi_locate_protocol(&simple_text_input_ex_guid, NULL);
This will find the first handle that provides
EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL, not necessarily the same as normal
console and you may inadvertently switch to another console. You have to
look for protocols on input handle.

> +      if (shift_state & (GRUB_EFI_RIGHT_SHIFT_PRESSED |
> +     result |= GRUB_TERM_SHIFT;
The keys which have natural meaning for shifted version never should
receive GRUB_TERM_SHIFT. E.g. Shift+d should give 'D', not
Easiest way is to add GRUB_TERM_SHIFT only if GRUB_TERM_EXTENDED is
already present.
What about providing keystatus function?

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]