[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v0] Make clear that passing --grub-mkimage to grub-install is
Vladimir 'φ-coder/phcoder' Serbinenko
Re: [PATCH v0] Make clear that passing --grub-mkimage to grub-install is not supported.
Mon, 02 Dec 2013 20:20:41 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9
On 02.12.2013 20:13, Jon McCune wrote:
> A reasonable alternative would be to completely remove all traces
> of --grub-mkimage, and simply have it fail like any other unrecognized
> flag to grub-install, but this will not be as clear to those who may
> go looking for what has happened to --grub-mkimage.
The reason for this option was to specify where grub-mkimage is located.
Your ways of using it were unsupported interface abuses. I have never
seen any script abusing grub-mkimage such way (that is other than yours).
> Signed-off-by: Jon McCune <address@hidden>
> util/grub-install-common.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/util/grub-install-common.c b/util/grub-install-common.c
> index 03c6f13..fcb4d66 100644
> --- a/util/grub-install-common.c
> +++ b/util/grub-install-common.c
> @@ -359,7 +359,8 @@ grub_install_parse (int key, char *arg)
> grub_util_error (_("Unrecognized compression `%s'"), arg);
> case GRUB_INSTALL_OPTIONS_GRUB_MKIMAGE:
> - return 1;
> + grub_util_error (_("Option --grub-mkimage is no longer supported"));
> + return 0;
> return 0;
Description: OpenPGP digital signature