[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] add grub_qsort_strcmp to use when sorting array of strings

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: [PATCH] add grub_qsort_strcmp to use when sorting array of strings
Date: Mon, 02 Dec 2013 06:34:01 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9

On 30.11.2013 11:59, Andrey Borzenkov wrote:
> В Sat, 30 Nov 2013 11:39:12 +0100
> Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:
>> On 29.11.2013 18:01, Andrey Borzenkov wrote:
>>> Compare function used in qsort gets arguments by reference, so strcmp
>>> cannot be used directly - it expects pointer to char, but gets pointer
>>> to pointer to char.
>>> Introduce new helper grub_qsort_strcmp and use it in grub-install.
>>> This helper is going to be used in a couple more places as well so
>>> add it to global file, not in grub-install.c.
>> Nice catch. But I don't we have enough use for grub_qsort_strcmp to make
>> it global. Can you make it static in grub-install.c ?
> I have pending patches to sort long lists in help output of commands
> (grub-mkimage and grub-probe target lists). They are long enough to
> wish some ordering.
Ok, then go ahead.
> _______________________________________________
> Grub-devel mailing list
> address@hidden

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]