Re: [PATCH] Explicitly check for linking format to use for efiemu64 module

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 25.11.2013 18:42, Andrey Borzenkov wrote:
> В Mon, 25 Nov 2013 05:22:58 +0100
> Vladimir 'φ-coder/phcoder' Serbinenko <address@hidden> пишет:
> 
>>> +      CFLAGS="-m64 -nostdlib -O2 -mcmodel=large -mno-red-zone"
>>> +      LDFLAGS="-m64 -Wl,$format -nostdlib"
>> You need -static as otherwise on Apple systems it will try to pull in
>> the dynamic linker which we don't want (scratch comment about other
>> thread, I though of adding -static everywhere but it's no necessarry
>> after all)
> 
> I used the same flags as in Makefile. If -static is needed here should
> not it be added to grub-core/Makefile.am as well?
> 
>>> diff --git a/grub-core/Makefile.am b/grub-core/Makefile.am
>>> index e2da083..e6862b7 100644
>>> --- a/grub-core/Makefile.am
>>> +++ b/grub-core/Makefile.am
>>> @@ -421,7 +421,7 @@ efiemu64.o: efiemu64_c.o efiemu64_s.o $(TARGET_OBJ2ELEF)
>>>       $(TARGET_OBJCONV) -felf64 -nu -nd address@hidden $@ || exit 1; \
>>>       rm -f address@hidden; \
>> Here the check for apple linker has to be adjusted as
>> x$(EFIEMU64_LINK_FORMAT) = x-arch,x86_64
> 
> Mmm ... but I assume apple linker case *did* work before and it broke
> only for the case !TARGET_APPLE_LINKER. Should $(EFIEMU64_LINK_FORMAT)
> be added for apple linker case as well? I have no way to test it.
> 
What I mean is that TARGET_APPLE_LINKER is conditioned on link_format.
And in this case we should check for efiemu64_link_format. As for the
exact command, don't worry too much about it, I'll clean it up and unify
the two cases after your patch is merged.
> 
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
>

signature.asc
Description: OpenPGP digital signature