grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: grub2 boot root-on-zfs errors


From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: grub2 boot root-on-zfs errors
Date: Sat, 23 Nov 2013 02:09:23 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9

> 40   pid = grub_util_exec_pipe ((const char * []){ "ofpathname", dev,
> NULL }, &fd);
> 41   if (!pid)
> 42
Why did you remove the whole chunk of code here?
Please use ptach command to apply patches, not some manual way.
> 43   FILE *fp = fdopen (fd, "r");
> 44   get_ofpathname (const char *dev)
> 45   if (!fp)
> 46     goto fail;
> 47
> 48   while (!feof (fp))
> 49     {
> 50       size_t r;
> 51    if (alloced == offset)
> 52       {
> 53         alloced *= 2;
> 54         ret = xrealloc (ret, alloced);
> 55       }
> 56      r = fread (ret + offset, 1, alloced - offset, fp);
> 57      offset += r;
> 58    }
> 59
> 60   fclose (fp);
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]