[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix qsort invocation in grub-install
|
From: |
Vladimir 'φ-coder/phcoder' Serbinenko |
|
Subject: |
Re: [PATCH] fix qsort invocation in grub-install |
|
Date: |
Sun, 10 Nov 2013 15:39:20 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131005 Icedove/17.0.9 |
On 10.11.2013 15:26, Andrey Borzenkov wrote:
> Order of elements number and size is reversed.
>
Go ahead.
> ---
> util/grub-install.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/grub-install.c b/util/grub-install.c
> index 11010cc..87a0b3b 100644
> --- a/util/grub-install.c
> +++ b/util/grub-install.c
> @@ -560,7 +560,7 @@ device_map_check_duplicates (const char *dev_map)
>
> fclose (fp);
>
> - qsort (d, sizeof (d[0]), filled, (int (*) (const void *, const void
> *))strcmp);
> + qsort (d, filled, sizeof (d[0]), (int (*) (const void *, const void
> *))strcmp);
>
> for (i = 0; i + 1 < filled; i++)
> if (strcmp (d[i], d[i+1]) == 0)
>
signature.asc
Description: OpenPGP digital signature