[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: grub2 claims grub.cfg is out of partition

From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: grub2 claims grub.cfg is out of partition
Date: Thu, 21 Jul 2011 00:31:51 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110626 Iceowl/1.0b2 Icedove/3.1.11

On 21.07.2011 00:28, Samuel Thibault wrote:
> tags 634799 + upstream patch
> thanks
> Hello,
I've looked into it and arrived to the similar conclusion that the with inode = 0 is the problem. However I think no such
entries should be there in the first place. In any case GRUB must be
robust to such corruptions but I'd recommend to fix Hurd ext2
implementation as well.
> Digging a bit with the issue, it seems grub2 does not ignore entries
> with inode == 0 while it should. See linux' ext2_readdir() in
> fs/ext2/dir.c doing it:
>               for ( ;(char*)de <= limit; de = ext2_next_entry(de)) {
>                       if (de->inode) {
>                         ...
>                       }
>               }
> The attached patch fixes it. Shall I commit it to upstream grub2?
> Samuel

Vladimir 'φ-coder/phcoder' Serbinenko

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]