Re: grub themes fail to load due to missing dependencies

[Vladimir 'φ-coder/phcoder' Serbinenko]

Mario Vazquez wrote:
> Grub 1.98 comes with the gfxmenu patch. The code used to include the
> entries in 00_header currently only adds the theme name, but nothing
> else. Due to either a bug or feature, currently grub do not load
> dependencies automatically. This means that when using a theme, it
> will not load the image modules or fonts required by the selected
> theme, causing it to fail to load at all.
>
>   
Good idea but the implementation has problems like e.g: it may load the
same module twice in a setup like:
a.png
b.jpg
c.png
I've made my patch based on your idea and I'm currently testing and
comitting it.
> I included a patch that searches the theme directory, and add the
> entries just before the theme file.
>
> How to reproduce:
>  1. Put a GRUB_THEME entry with your theme in /etc/default/grub.
>  2. Generate your grub.cfg with grub-mkconfig
>  3. Reboot
>  4. The theme will not load at all.
>
> The patch was tested against both grub 1.98 and trunk r2263
> https://savannah.gnu.org/bugs/?29251
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

signature.asc
Description: OpenPGP digital signature