grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC][PATCH] Basic unit testing support for GRUB


From: Robert Millan
Subject: Re: [RFC][PATCH] Basic unit testing support for GRUB
Date: Mon, 16 Nov 2009 22:21:56 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

On Fri, Nov 13, 2009 at 11:15:41PM +0530, BVK wrote:
> Hi,
> 
> 
> Attached is the (experimental branch) patch for unit testing that I
> have in mind for GRUB.  Please let me know your comments.
> 
> It provides "make check" target which would build and execute test
> programs from "tests" directory.  We can write small programs to test
> specific functions in GRUB.  For example, attached patch has sample
> program comparing grub_sprintf behavior against standard sprintf
> output (from glibc).
> 
> Note that it currently has few gotchas, like using TARGET_CC instead
> of BUILD_CC, no support for XPASS, XFAIL tests, etc.

Some parts don't follow our coding style;  please check with indent(1)
utility, it should produce the right indentation.  Also, we use C-style
/**/ syntax for comments.

Ah, and could you include a ChangeLog entry?

Thank you!

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]