Re: gettext in build system

[Jordi Mallach]

Hi Robert,

Please excuse the total lack of input on this issue, I've been really
busy the last few weekends.

On Mon, Nov 16, 2009 at 12:59:09AM +0100, Robert Millan wrote:
> On Mon, Nov 16, 2009 at 12:13:55AM +0100, Robert Millan wrote:
> > +po/messages.pot: po/POTFILES
> > +   xgettext --from-code=utf-8 --keyword=_ -f $< -o $@
> > +
> > +po/*.po: po/messages.pot
> > +   msgmerge -U $@ po/messages.pot
> > +
> > +po/%.mo: po/%.po
> > +   $(MKDIR_P) $$(dirname $@)
> > +   msgfmt -c --statistics -o $@ $^
> 
> Obvious missing thing is that these should be autoconffed.

Also, as something merely cosmetic, messages.pot could be $(PACKAGE).pot,
which is more common.

> > +#define _(str) gettext(str)
> And I'm not sure if this is the right place to define _.  Isn't there
> a system-wide definition?

This, and others, sometimes go in a common .h to avoid duplication. Many
grub utilities are going to add this kind of stuff.

> > +  textdomain ("grub");
> What's the usual way to handle this?  TEXTDOMAIN macro?

As Colin said, $PACKAGE is common.
I haven't tested this patch yet, but I'm not sure if a bindtextdomain()
call is needed here too.

The rest looks good, given there's no automake.

Jordi
-- 
Jordi Mallach Pérez  --  Debian developer     http://www.debian.org/
address@hidden     address@hidden     http://www.sindominio.net/
GnuPG public key information available at http://oskuro.net/

signature.asc
Description: Digital signature