grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] turn grub-emu into a port


From: Robert Millan
Subject: Re: [PATCH] turn grub-emu into a port
Date: Sat, 31 Oct 2009 11:29:03 +0100
User-agent: Mutt/1.5.18 (2008-05-17)

On Sat, Oct 31, 2009 at 11:18:03AM +0100, Vladimir 'phcoder' Serbinenko wrote:
> >> -  return (tv.tv_sec * GRUB_TICKS_PER_SECOND
> >> -         + (((tv.tv_sec % GRUB_TICKS_PER_SECOND) * 1000000 + tv.tv_usec)
> >> -            * GRUB_TICKS_PER_SECOND / 1000000));
> >> +  GRUB_COMPILE_TIME_ASSERT (GRUB_TICKS_PER_SECOND == 1000000);
> >> +  return (tv.tv_sec * 1000000 + tv.tv_usec);
> I meant: keep GRUB_TICKS_PER_SECOND=1000000 per default but allow easy
> adjustment to any number by coder

Ah, you mean instead of assuming (and asserting) that they're 1000000, leave
it as a hardcoded "#define GRUB_TICKS_PER_SECOND 1000000" so that this can
be changed at source level?

Seems fine.  If that's what you mean, I'll adjust the patch and add it to
experimental.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]