Re: [GITGRUB] New menu interface (implementation)

[Bean]

On Sun, Oct 11, 2009 at 6:54 AM, Michal Suchanek <address@hidden> wrote:
> Hello
>
> 2009/10/10 Bean <address@hidden>:
>> Hi,
>>
>> Update:
>>
>> Add command menu_start, menu_popup, menu_toggle_mode and menu_refresh.
>
> This is very good, it's possible to run something with the menu now.
>
>
> I wonder why the popup menu shows on the same screen as the main menu.
> AFAIK it is impossible to return to the main menu without closing the
> popup first. There does not seem to be any protection from the popup
> overlapping the main menu (which would be ugly) and if there were the
> main menu would needlessly occupy space in case the popup contained
> more content (think the long help texts that distributions include in
> syslinux).
>
> I suggest that the popup should replace the "screen" element and when
> it is closed the previous screen should be restored. It might be nice
> to include the command line as the first screen under the main menu.

Hi,

Sometimes it's desired to place the popup alongside the current
screen. For example, we can use this to implement the submenu, which
is pop near the current menu. Anyway, to replace screen, you can use a
non transparent panel as the top widget of popup:

panel
{
  width = 100%
  height = 100%
  background = ",,black,#0"
}

>
>
> Is it possible to include the menu in the main config file?
>
> I am not sure this would be that much useful because a font is
> required for menu in graphics mode anyway so there are very few cases
> when a single file would be enough. It might be nice for people who do
> have text mode, though.
>
>
> The terminal is somewhat odd.
>
> The tab character does not seem to work in the terminal. When I write
> "ls (" and press tab nothing happens.

The tab completion function from normal.mod yet haven't been integrated yet.

>
> Pressing space (or any other key) in text mode seems to draw the
> terminal cursor all over the terminal area momentarily.

Right, I should hide the cursor while updating the screen.

>
> Pressing backspace at the prompt (when there is nothing typed or
> everything is already deleted) seems to break the terminal.

The term would execute the line only if it starts with prompt "grub>
", otherwise it's just an editor, this means you can use UP/PAGEUP to
go back to previous content easier. when you use backspace at prompt,
the prompt is changed so it can't be identified anymore, you can use
DOWN to start a new line and a new prompt would be printed.

>
> When I type help it waits some seconds and then shows like 2/3-screen
> of text. This is because scrolling always brings last line somewhere
> into 2/3 of the screen and leaves the last 1/3 blank. I know gfxterm
> is already slow but the new terminal seems even slower. The new
> terminal does not even show the scrolled part of the text at all. This
> would be useful if we had less/more. It is true the scrolling in
> gfxterm is abysmally slow but at least it shows the text.

Currently the terminal always return dummy width 0x7f, so the line
would be very long in help command, I can return a more reasonable
value.

-- 
Bean

gitgrub home: http://github.com/grub/grub/
my fork page: http://github.com/bean123/grub/