Re: Require at least gcc 4.2

[Robert Millan]

On Sat, Sep 05, 2009 at 11:01:32PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> On Thu, Sep 3, 2009 at 4:58 PM, Robert Millan<address@hidden> wrote:
> > On Tue, Sep 01, 2009 at 06:07:04PM +0200, Robert Millan wrote:
> >> On Tue, Sep 01, 2009 at 03:44:18PM +0200, Vladimir 'phcoder' Serbinenko 
> >> wrote:
> >> >
> >> > +AC_CACHE_CHECK([whether gcc is recent enough], grub_cv_cc_recent, [
> >> > +  CFLAGS=
> >> > +  AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
> >> > +#if defined (__GNUC__) && (__GNUC__ < 4 || __GNUC_MINOR__ < 2)
> >> > +#error Use at least GCC 4.2
> >> > +#endif
> >>
> >> This would fail with e.g. GCC 5.0.  Other than this, the patch is fine.
> >>
> >> If Bean wants to add a configure option (e.g. like QEMU's 
> >> --disable-gcc-check)
> >> so that this requirement can be overriden, that's ok too.
> >
> > Btw, INSTALL file still says 2.95.  If we do this, it should be adjusted as
> > well.
> >
> Cosidering recent gcc's still have nested function bug I consider
> forcing 4.2 is absolutely unnecessary.
> However INSTALL needs to be upgraded and mention a newer GCC since
> grub2 isn't compileable with gcc 2.95

David et al, can we agree on a minimal version of GCC that we should recommend?

For mentioning in the INSTALL file only.  I assume nobody's interested in
gcc 2.95.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."