Re: [PATCH] Detect key modifier status in 'sleep --interruptible'

[Colin Watson]

On Fri, Aug 28, 2009 at 02:44:15PM +0200, Robert Millan wrote:
> On Wed, Aug 26, 2009 at 09:26:06PM +0100, Colin Watson wrote:
> > If GRUB_HIDDEN_TIMEOUT is set to a non-zero value, I would use sleep
> > rather than keystatus, I think. (At least, if I decided I wanted to
> > support that configuration; I'm not quite sure yet.) In that case I'd
> > want the sleep to be interruptible by pressing Shift for consistency
> > with the zero-delay case.
> > 
> > However, since this is essentially an artifact of our configuration and
> > doesn't introduce any new configuration file words, I could keep this
> > part as an Ubuntu-specific patch with relatively little trouble.
> 
> Please do for now.  I'd rather not rush when discussing this part.

Consider it done.

> > OK, and doing so helped me notice that I'd left a Get_Idle request in
> > there by mistake from debugging. Updated patch follows. There are a few
> > changes unrelated to the main body of the patch as a result; do you want
> > these split out?
> 
> No need, this looks good.  Please commit.

Committed, thanks.

-- 
Colin Watson                                       address@hidden