grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gfxterm clear_char


From: Pavel Roskin
Subject: Re: [PATCH] gfxterm clear_char
Date: Wed, 29 Jul 2009 18:15:45 -0400

On Tue, 2009-07-28 at 22:15 -0700, Joe Auricchio wrote:

> Eine kleine gfxterm.c cleanup

Applied with formatting changes.

>  static void
> +clear_char(struct grub_colored_char *c)

Space is needed before the parenthesis.

> +{
> +    c->code = ' ';

Indentation should be 2 spaces, not 4.

>    for(i = 0; i < virtual_screen.columns * virtual_screen.rows; i++)
>      {

This brace is no longer needed.

> Index: src/ChangeLog

It would be more convenient if the ChangeLog entry is posted inline
rather than inside the patch.

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]