Re: [Fwd: Re: Bug#495949: grub-common: grub-probe segfaults]

[Vladimir 'phcoder' Serbinenko]

> -      if (! strcmp (dest_partmap, "pc_partition_map"))
> -       grub_util_warn ("This msdos-style partition label has no post-MBR 
> gap; embedding won't be possible!");
> -      else
> -       grub_util_warn ("This GPT partition label has no BIOS Boot Partition; 
> embedding won't be possible!");
> +      grub_util_warn ("Cannot identify partition map.");
This message will appear on partionless disks. Perhaps more or more
precise information is better (we're in core.img here)
> +      grub_util_warn ("Embedding on partition type %s is unsupported",
> +                     dest_partmap);
>       goto unable_to_embed;
>     }
This should be a harder error. Only few partition schemes have a place
for bootsector. Writing to "bootsector" is likely to destroy partition
map. If more partitions are sane for install (e.g. sun_pc I recently
implemented for solaris is) then I prefer to add them manually
>
>
> --
> Regards,
> Pavel Roskin
>
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git