Re: [PATCH] change --enable-efiemu to --enable-efiemu64

[Pavel Roskin]

On Sat, 2009-07-18 at 20:32 +0200, Robert Millan wrote:
> On Fri, Jul 17, 2009 at 06:15:57PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> > Like previously discussed efiemu32 can always be compiled hence this patch
> 
> This does a few more things than just toggle compile options.  Could you
> split the patch?

I second that.

Also, we need to look at things from the users' point of view.  Users
don't know what efiemu64 is and why it's so special that they are told
about it at the of the configure output.  Why it is more important that
efiemu32?  Why is efiemu64 only needed on the i386-pc platform?

I believe efiemu64 is only more important from the implementation point
of view, as it requires an additional test to be passed.  But most users
won't need efiemu64 at all.

If we add efiemu compilation to the x86_64-efi support, efiemu32 will be
special.  So it would be better to report something like "efiemu support
- 32-bit and 64-bit" if we care to report.

I suggest that you google for "The Paradox of Choice".  Sure, there are
difference between end users and those compiling GRUB from the sources,
but you'll get the idea.  Sometimes we should make the choice.

-- 
Regards,
Pavel Roskin