grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] unused constants in i386/boot.h


From: Pavel Roskin
Subject: Re: [PATCH] unused constants in i386/boot.h
Date: Tue, 14 Jul 2009 14:55:44 -0400

On Tue, 2009-07-14 at 19:37 +0200, Robert Millan wrote:
> On Sun, Jul 12, 2009 at 09:21:07AM -0400, Pavel Roskin wrote:
> > Quoting Yves Blusseau <address@hidden>:
> >
> >>> As long as boot/i386/pc/boot.S has the variables whose offset these macros
> >>> are describing, I think it's fine to keep them.
> >
> > I'd rather not keep the macros that are not used outside boot.S.  They  
> > give a wrong impression that somebody somewhere needs to know that  
> > offset.
> 
> Ok, let's remove them.  I don't feel strongly about it.

I'm working on a patch series that would remove unnecessary stuff and
widen the BPB.

-- 
Regards,
Pavel Roskin




reply via email to

[Prev in Thread] Current Thread [Next in Thread]