grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] use $(target_cpu) in conf/*.rmk


From: Robert Millan
Subject: Re: [PATCH] use $(target_cpu) in conf/*.rmk
Date: Wed, 1 Jul 2009 15:00:02 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

On Mon, Jun 29, 2009 at 09:05:12PM -0400, Pavel Roskin wrote:
> Quoting Robert Millan <address@hidden>:
>
>>
>> This patch replaces a few hardcoded architecture names in conf/*.rmk
>> with $(target_cpu).  It makes it easier to share code.
>>
>> As a result of this, the setjmp module declarations are unified.
>>
>> grub-emu can too be unified similarly, although   
>> util/$(target_cpu)/$(platform)/misc.c
>> might be better off with a complete merge (they're always identical,  
>> or almost).
>
> Fine with me.

Committed.

> I'm actually thinking of making dl.c similar to each other by using the 
> notation without "32" and "64".  At least it would be easier to compare 
> them.

Yeah, I was thinking that too.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]